Idealplusrad eos for gr; shock capture for gr #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and u can deal with ientropy and ietotal
…nes for var gamma
…ssure from entropy and density
…d too large entropy
…hine precision error could be negligible
…y; simplify slope limiter; remove ifdefs (danieljprice#55)
s-neilson
pushed a commit
to s-neilson/phantom
that referenced
this pull request
Mar 18, 2023
Idealplusrad eos for gr; shock capture for gr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
new physics
Description:
Implement new entropy s to use idealplusrad eos 12 for gr
Velocity reconstruction to help shock capture for gr
Testing:
Shock tubes with both functions agree with analytics
TDE with s agrees with the original K
Did you run the bots? no