Stratified EOS - Law and Dartois prescriptions #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test of stratified eos is failing when compiled with DEBUG=yes, probably because some variables are used without being initialised? |
|
I thought I had found the issue but looks like not yet! Will keep trying |
s-neilson
pushed a commit
to s-neilson/phantom
that referenced
this pull request
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Added in separate modules for running and testing the temperature stratified equation of state, now also includes Dartois et al. (2003) prescription which matches mid plane temperature
Description:
Added in separate modules for running and testing the EOS, and modified the Makefile to include these, the setup_disc routine to contain relevant parameters, and the eos.F90 and test_eos.f90 files to call to the new functions
Testing:
Passed entire test suite and eos test suite
Did you run the bots? no