(eos.F90) Fixed bug in Eos 14: the original prescrition was commented… #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and replaced by one normalised by the mass of the primary instead of using the total binary mass.
|
We need a unit test for this eos to prevent issues like this in future |
s-neilson
pushed a commit
to s-neilson/phantom
that referenced
this pull request
Mar 18, 2023
(eos.F90) Fixed bug in Eos 14: the original prescrition was commented…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and replaced by one normalised by the mass of the primary instead of using the total binary mass.
Type of PR:
Bug fix
Description:
Restored to the original Farris et al. (2014) prescription implemented in Ragusa et. al (2016).
Testing:
Compared the results with other codes
Did you run the bots? yes