Timers for local and remote sums in density and force #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tom into memory-optimisation # Conflicts: # build/Makefile # src/main/memory.F90
because maxprocs is needed to get the right size, which we don't want to set as a parameter subroutines adjusted accordingly (replaced direction with remote_export)
amend previous commit bugfix: missing nprocs import amend previous commit
necessary for test suite
s-neilson
pushed a commit
to s-neilson/phantom
that referenced
this pull request
Mar 18, 2023
Timers for local and remote sums in density and force
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
other
Description:
Add timers to density and force routines to compare the time spent computing sums on local particles vs remote particles.
Add column to timings:
load bal- measures the MPI work load balance, where 100% is perfectly balanced. Defined as the mean CPU time of every task except for the slowest, divided by the slowest time.Testing:
Verify timers are subsets of their parents
Did you run the bots? no