Fix incorrectly reduced variables in nimhd test #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix
Description:
Required for #217
In a93bc90, as part of implementing MPI support for nimhd tests, the L2 error variables were reduced across tasks.
There is a typo resulting in the
v_x
andB_y
error being overwritten by the density error. This produces a test failure due to the tolerance not being met.In df72df1, NICIL 2.1 was added to phantom, where the tolerance for
B_y
was changed totolb=3.1d-2
. This was change was made possibly because the apparent improved accuracy was wrongly attributed to improvements to the code, rather than because the the density error was overwriting theB_y
error.tolb
has been reverted to the original value of1.1d-1
.This bug is not yet covered by the automated test suite because #217 has not been merged yet, and needs to be tested manually using the commands below.
Testing:
Did you run the bots? no, not required