Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix
Description:
Required for #217, discovered when
mpirun -n 4
was addedIn ptmass.F90, during sink creation, whether the particle is at the potential minimum is checked:
This check fails because an identical particle distribution gets created on every task, resulting in close comparisons when determining which particle to create a sink at.
This is fixed by only creating the particles on the master task, and allowing derivs to rebalance them.
itest
needs to be calculated after calling derivs or else it will be incorrect. Thexcofm
calculation has been removed because the result is not used anywhere.Testing:
Did you run the bots? yes, pre-commit