Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sink heating #216

Merged
merged 8 commits into from
Feb 13, 2022
Merged

Sink heating #216

merged 8 commits into from
Feb 13, 2022

Conversation

themikelau
Copy link
Collaborator

Type of PR:
Implement ability for sink particles to heat gas particles within softening radius.

Description:

  • Luminosity of point mass is specified via the ilum column. A new column, imass_enclosed, has been added to store the mass enclosed within twice the softening length, 2*hsoft.

Testing:

  • Observed reasonable stability of star with a sink-particle core radiating at the stellar luminosity, with radiation transport turned on.

Did you run the bots?
No.

@danieljprice danieljprice marked this pull request as ready for review February 11, 2022 02:18
@danieljprice
Copy link
Owner

@themikelau this should be ready to go. I cleaned up a couple of things in test_eos so please check everything is ok from your side (in particular I made a helper routine to avoid the repeated code to setup the rho, T grid; since the choice seemed arbitrary I made the limits the same for both, unless there is a reason you wanted different limits tested for idealplusrad vs. hormone?)

@themikelau
Copy link
Collaborator Author

@danieljprice Thanks for cleaning up test_eos. Your changes are fine if the test passes.

@danieljprice danieljprice merged commit 09ffe7b into master Feb 13, 2022
@danieljprice danieljprice deleted the sink-heating branch February 13, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants