Copy dustprop and dustproppred between MPI tasks when moving particles #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix
Description:
#206 fixed a bug introduced by ed59ad7 where a feature was incorrectly implemented for MPI causing an error for non-dustgrowth runs by removing the change to the
ipartbufsizecounter. This fixed non-dustgrowth runs, but not dustgrowth runs.The symptom is incorrectly calculated
dtdue tograindensbeing zero becausedustpropanddustproppredare not transported between MPI tasks. The fix is to communicate those variables using MPITesting:
The
growthbenchmark now runs to completion with MPI, whereas it previously did not. There is still no automated test for dustgrowth + MPI.Did you run the bots? yes