Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem setting up a disc with binary potential #429

Open
martinatoscani opened this issue Jun 12, 2023 · 0 comments
Open

problem setting up a disc with binary potential #429

martinatoscani opened this issue Jun 12, 2023 · 0 comments

Comments

@martinatoscani
Copy link
Contributor

martinatoscani commented Jun 12, 2023

when setting up a fixed binary + disc there is a problem in setting m1 and m2: massratio (binarymassr) is ambiguous and confusing in the code. Primary and secondary mass definition is not in line with what expected theoretically, which causes problem in the definition of the potential. Disc is behaving in weird way if if unequal binary mass objects are used.

Proposed solution: remove the parameter binarymassr in extern_binary.f90 and replace with m1 and m2 similarly to what is in extern_binary_gw.f90 .

We also need to change this in the setup routine for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant