Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for gui. #856

Merged
merged 24 commits into from
May 8, 2023
Merged

Add tests for gui. #856

merged 24 commits into from
May 8, 2023

Conversation

tov101
Copy link
Contributor

@tov101 tov101 commented Apr 22, 2023

Changes:

File: src/asammdf/gui/utils.py

  • self.qfinished.connect(lambda: QtCore.QCoreApplication.processEvents())
    • after progress dialog is closed or cancelled, distroy function didn't get the chance to do the job.
  • class ProgressDialog inherits QtWidgets.QProgressDialog which inherits PySide6.QtWidgets.QDialog
    • QDialog has own class variable finished which emits an int.
    • class variable finished of ProgressDialog was refactored in order to avoid being overwritten by the on of QDialog.

Reason: TypeError was raised because of this during tests developments and manual usage.

Error: <class 'TypeError'>	 
finished(int) needs 1 argument(s), 0 given!

Details: 2023-04-24, 12:29:07
--------------------------------------------------------------------------------
<class 'TypeError'>	 
finished(int) needs 1 argument(s), 0 given!
--------------------------------------------------------------------------------
  File "D:\gh\asammdf\src\asammdf\gui\utils.py", line 312, in thread_complete
    self.finished.emit()

File: src/asammdf/gui/batch.py

  • Run black and isort in order to get style checks passed.

File: src\asammdf\gui\widgets\tree.py

524: DeprecationWarning: 'exec_' will be removed in the future. Use 'exec' instead.

File: src\asammdf\gui\widgets\plot.py

5696: RuntimeWarning: overflow encountered in scalar subtract

@danielhrisca danielhrisca changed the base branch from master to development April 24, 2023 07:07
@tov101 tov101 changed the base branch from development to master April 24, 2023 17:24
@tov101 tov101 changed the base branch from master to development April 24, 2023 17:25
@tov101 tov101 changed the base branch from development to master April 24, 2023 17:26
@tov101 tov101 changed the base branch from master to development April 24, 2023 17:26
@tov101
Copy link
Contributor Author

tov101 commented Apr 24, 2023

Green again.. but I'm not ok with that segmentation fault anymore.

@danielhrisca danielhrisca merged commit 864eda9 into danielhrisca:development May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants