Use HTTPS URL on Google Fonts #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pongstr thanks for the pull request! Using the protocol-relative URLs means you cannot open the generated HTML locally unless using a web server. What if we just default all of them to HTTPS? |
|
@danielgtaylor I agree with making it HTTPS only. The protocol-relative URL pattern is now seen as an anti-pattern, and if the asset is available with TLS, then you should always use TLS to get it (https). We've taken this approach in pelican. |
|
@danielgtaylor @kylef I agree with that 100% sorry I didn't realized that immediately. PR Updated! :) |
Use `https` instead of protocol-relative URL to make generated HTML to work locally even without a webserver. ``` @import url('https://fonts.googleapis.com/css?family=Roboto:400,700|Inconsolata|Raleway:200'); ``` instead of: ```css @import url('//fonts.googleapis.com/css?family=Roboto:400,700|Inconsolata|Raleway:200'); @import url('http://fonts.googleapis.com/css?family=Roboto:400,700|Inconsolata|Raleway:200'); ```
pongstr
changed the title
|
What is the eta on this? |
|
Sorry about that, I was out on vacation and this dropped from my radar. |
danielgtaylor
added a commit
that referenced
this pull request
Aug 31, 2015
Use HTTPS URL on Google Fonts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since google fonts are available on SSL maybe use the
protocol-relative URL instead?
instead of: