Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why not fatal error level log? #80

Closed
chinghoi-tam opened this issue Aug 27, 2023 · 4 comments
Closed

why not fatal error level log? #80

chinghoi-tam opened this issue Aug 27, 2023 · 4 comments
Assignees
Labels
accepted Issue has been accepted and inserted in a future milestone enhancement
Milestone

Comments

@chinghoi-tam
Copy link

Excuse me, Why is there no fatal error level?

@danieleteti
Copy link
Owner

No particular reason. We can plan to add it.

@danieleteti danieleteti self-assigned this Sep 27, 2023
@danieleteti danieleteti added enhancement accepted Issue has been accepted and inserted in a future milestone labels Sep 27, 2023
@danieleteti danieleteti added this to the 1_5_0 milestone Sep 27, 2023
danieleteti added a commit that referenced this issue Sep 27, 2023
@luebbe
Copy link
Contributor

luebbe commented Sep 28, 2023

Very nice. I wanted to suggest the same for exeption logging.

@danieleteti
Copy link
Owner

@luebbe regarding exceptions I've different feeling. What's the "log level" of an exception? There are fatal exceptions and "normal" exceptions (user wrote "a" in a number only field). So, while is very simple to implement I really don't have a crear vision about it.

@luebbe
Copy link
Contributor

luebbe commented Sep 28, 2023

Of course. Not every exception is fatal. Our "well handled" exceptions only have debug or info level if they are logged at all. I was more thinking about the catastrophic ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issue has been accepted and inserted in a future milestone enhancement
Projects
None yet
Development

No branches or pull requests

3 participants