Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor routes #35

Closed
danielemery opened this issue Aug 1, 2024 · 0 comments
Closed

Refactor routes #35

danielemery opened this issue Aug 1, 2024 · 0 comments
Assignees
@danielemery
Labels
breaking Breaking change (requires major version bump)
Milestone
v2.0

Comments

@danielemery
Copy link
Owner

In a future version of keys multiple content types will be supported (#33 and #34) as well as the capability to load known_hosts (#19).

With these sets of features in mind (especially supporting html content types) it makes less sense to service keys at /api.

Instead descriptive names at the root should be used, eg.:

  • /keys or /authorized_keys
  • /hosts or /known_hosts
@danielemery danielemery added the breaking Breaking change (requires major version bump) label Aug 1, 2024
@danielemery danielemery self-assigned this Aug 1, 2024
@danielemery danielemery added this to the v2.0 milestone Aug 1, 2024
danielemery added a commit that referenced this issue Aug 4, 2024
@danielemery
#35 Rename /api route to new set of supported routes
5e3ddce 
- `/keys`
- `/authorized_keys`

(Trailing slashes will now also yield a result).
danielemery added a commit that referenced this issue Aug 4, 2024
@danielemery
#35 Rename /api route to new set of supported routes
b957699 
- `/keys`
- `/authorized_keys`

(Trailing slashes will now also yield a result).
danielemery added a commit that referenced this issue Aug 4, 2024
@danielemery
#35 Rename /api route to new set of supported routes
1789a87 
- `/keys`
- `/authorized_keys`

(Trailing slashes will now also yield a result).
danielemery added a commit that referenced this issue Aug 4, 2024
@danielemery
#35 Rename /api route to new set of supported routes
e059ba7 
- `/keys`
- `/authorized_keys`

(Trailing slashes will now also yield a result).
danielemery added a commit that referenced this issue Aug 17, 2024
@danielemery
#35 Rename /api route to new set of supported routes
98f97b6 
- `/keys`
- `/authorized_keys`

(Trailing slashes will now also yield a result).
danielemery added a commit that referenced this issue Aug 27, 2024
@danielemery
#35 Rename /api route to new set of supported routes
7526b9d 
- `/keys`
- `/authorized_keys`

(Trailing slashes will now also yield a result).
danielemery added a commit that referenced this issue Aug 27, 2024
@danielemery
#35 Rename /api route to new set of supported routes
bcf41c7 
- `/keys`
- `/authorized_keys`

(Trailing slashes will now also yield a result).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielemery danielemery

Labels
breaking Breaking change (requires major version bump)
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
1 participant
@danielemery