Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see there is another pull request on the same topic: #21
Changes here are really small:
element.find(className)
tofindDivByClassName = function(element, className)
angular.element('body')
toangular.element($document).find('body')
$slider.width()
to$slider[0].offsetWidth
(and same with height)I tested it in Chrome and FF and it works. I can't test it under IE because I'm using Linux. But
offsetWidth
is IE compatible.Regarding
findDivByClassName
, I first usedgetElementsByClassName
but it appeard not to be IE8 compatible so I went for a custom method, that only usesangular.find(tagName)
which must be based ongetElementsByTagName
which is IE8 compatible.Here it is:
Hope this gets merged soon! 😄
Awesome directive by the way!