Process calls in current process #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `CallProcessor` just `awaits` the result of the `Task` anyway, the current implementation is actually _slower_. This is because Elixir has to spin up a new process to handle the call, and then receive the output. It's much simpler to just handle the call in the current process, and avoid the overhead of starting a pointless new process.
danielberkompas
added a commit
that referenced
this pull request
Sep 12, 2015
Process calls in current process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
CallProcessorjustawaitsthe result of theTaskanyway, thecurrent implementation is actually slower. This is because Elixir has
to spin up a new process to handle the call, and then receive the
output. It's much simpler to just handle the call in the current
process, and avoid the overhead of starting a pointless new process.