Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zap2it: Add basic option for language handling #10

Merged
merged 5 commits into from
May 19, 2021

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented May 19, 2021

Currently in testing to confirm if this solves the parsing error found in #9

If this turns out to run OK, a better option would be to define a configuration file with the list of channels that are in other languages than 'en' so that we can parse that at run time and apply the proper language fields where needed.

In the meantime, this simple fix might turn out ok...

@th0ma7 th0ma7 changed the title wzap2it: Add basic option for language handling zap2it: Add basic option for language handling May 19, 2021
@th0ma7
Copy link
Contributor Author

th0ma7 commented May 19, 2021

The few bits of changes made it to work!
Adding <icon src= also allowed to get an image to work for all shows.
I may add a few other bits here and there to further align with other standard... but ain't that much of a coder so feel free to chim in..

@daniel-widrick
Copy link
Owner

Merging fixes

@daniel-widrick daniel-widrick merged commit 03684f8 into daniel-widrick:master May 19, 2021
@th0ma7 th0ma7 deleted the language-fix branch May 23, 2021 10:44
@th0ma7 th0ma7 mentioned this pull request May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants