-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blob() breaking change in 7.3.4 using Karma + PhantomJS #1027
Comments
Added a check for Blob function in version 7.3.9. Should fix this issue. |
@danialfarid 7.3.9 did not fix this. Here's a stacktrace:
Changing https://github.com/danialfarid/ng-file-upload/blob/master/dist/ng-file-upload.js#L32 to:
Did the trick. MDN Blob - https://developer.mozilla.org/en-US/docs/Web/API/Blob |
The changed didn't get in this version, will be fixed in the next version |
Fixed in version 8.0.1 |
Darex1991
added a commit
to Darex1991/ng-file-upload
that referenced
this issue
Dec 17, 2015
Darex1991
added a commit
to Darex1991/ng-file-upload
that referenced
this issue
Dec 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@danialfarid just wanted to let you know that 7.3.4 introduced
Blob()
which is only supported in the "new" PhantomJS 2.0 (ariya/phantomjs#11013). Karma does not have (official) support for PhantomJS 2.0 yet (karma-runner/karma-phantomjs-launcher#56). So this may cause an unexpected breaking change that could be mentioned in a migration guide?Thanks.
We're staying with 7.3.3 for the time being :)
The text was updated successfully, but these errors were encountered: