Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auth-request deletion #5184

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

BlackDex
Copy link
Collaborator

2FA is needed to login even when using login-with-device. If the user didn't saved the 2FA token they still need to provide this. We deleted the auth-request after validation the request, but before 2FA was triggered.

Removing the deletion of this record from that point as it will get cleaned-up automatically anyways.

2FA is needed to login even when using login-with-device.
If the user didn't saved the 2FA token they still need to provide this.
We deleted the auth-request after validation the request, but before 2FA was triggered.

Removing the deletion of this record from that point as it will get cleaned-up automatically anyways.

Signed-off-by: BlackDex <[email protected]>
@BlackDex BlackDex requested a review from dani-garcia November 12, 2024 14:26
@dani-garcia dani-garcia merged commit e927b8a into dani-garcia:main Nov 12, 2024
5 checks passed
@BlackDex BlackDex deleted the fix-auth-request-with-2fa branch November 13, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants