remove superfluous asterisk #4901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-garcia
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Hmm a long time ago we had the asterisk to point to the this project is not associated with the Bitwarden project line, but at some point it got deleted. Should we instead add the asterisk back there?
Here's the old readme for example:
https://github.com/dani-garcia/vaultwarden/blob/a0ae032ea709bee1422a22b9dd022b0a06c33442/README.md
|
That line is still there it looks like, but a bit in-between other lines. Not sure if the asterisk is still needed though. There are multiple other locations where we mention Bitwarden or the clients and do not emphasize on the not being a part of.. |
3 tasks
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this pull request
Nov 1, 2024
Updating the Readme to be more modern and more clear. Added and moved several shields/badges and changed some default colors to have a better contrast. Added a Disclaimer section. Closes dani-garcia#4901 Closes dani-garcia#4930 Closes dani-garcia#4931 Closes dani-garcia#5024 Co-authored-by: ipitio <[email protected]> Co-authored-by: Robert Schütz <[email protected]> Co-authored-by: Yonas Yanfa <[email protected]> Co-authored-by: KUSUMA RUSHIKESH <[email protected]>
Merged
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this pull request
Nov 1, 2024
Updating the Readme to be more modern and more clear. Added and moved several shields/badges and changed some default colors to have a better contrast. Added a Disclaimer section. Closes dani-garcia#4901 Closes dani-garcia#4930 Closes dani-garcia#4931 Closes dani-garcia#5024 Co-authored-by: ipitio <[email protected]> Co-authored-by: Robert Schütz <[email protected]> Co-authored-by: Yonas Yanfa <[email protected]> Co-authored-by: KUSUMA RUSHIKESH <[email protected]>
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this pull request
Nov 1, 2024
Updating the Readme to be more modern and more clear. Added and moved several shields/badges and changed some default colors to have a better contrast. Added a Disclaimer section. Closes dani-garcia#4901 Closes dani-garcia#4930 Closes dani-garcia#4931 Closes dani-garcia#5024 Co-authored-by: ipitio <[email protected]> Co-authored-by: Robert Schütz <[email protected]> Co-authored-by: Yonas Yanfa <[email protected]> Co-authored-by: KUSUMA RUSHIKESH <[email protected]>
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this pull request
Nov 1, 2024
Updating the Readme to be more modern and more clear. Added and moved several shields/badges and changed some default colors to have a better contrast. Added a Disclaimer section. Closes dani-garcia#4901 Closes dani-garcia#4930 Closes dani-garcia#4931 Closes dani-garcia#5024 Co-authored-by: ipitio <[email protected]> Co-authored-by: Robert Schütz <[email protected]> Co-authored-by: Yonas Yanfa <[email protected]> Co-authored-by: KUSUMA RUSHIKESH <[email protected]>
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this pull request
Nov 2, 2024
Updating the Readme to be more modern and more clear. Added and moved several shields/badges and changed some default colors to have a better contrast. Added a Disclaimer section. Closes dani-garcia#4901 Closes dani-garcia#4930 Closes dani-garcia#4931 Closes dani-garcia#5024 Co-authored-by: ipitio <[email protected]> Co-authored-by: Robert Schütz <[email protected]> Co-authored-by: Yonas Yanfa <[email protected]> Co-authored-by: KUSUMA RUSHIKESH <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.