-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple domains support #3870
Open
BlockListed
wants to merge
41
commits into
dani-garcia:main
Choose a base branch
from
BlockListed:multiple-domains-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+381
−165
Open
Multiple domains support #3870
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
80d3c61
add configuration support for multiple domains
BlockListed 40edfa5
implement mutli domain support for auth headers
BlockListed 303eb30
remove domain_paths hashmap, since it's no longer used
BlockListed 17923c3
replace domain with base_url
BlockListed 0ebd877
make admin work with multi-domains
BlockListed 2c7b739
make fido app-id.json work with multi-domains
BlockListed e313745
make domain protocol validation work with multi-domains
BlockListed 0d7e678
make mail work with multi-domains
BlockListed 5462b97
make cors work with multi-domains
BlockListed f82a142
get domain and origin with single extractor
BlockListed b5dea32
make attachments / ciphers support multi-domains
BlockListed 968ed8a
make sends support multi-domain
BlockListed 42e1018
make admin support hostinfo
BlockListed 12c0005
make webauthn support multi-domain
BlockListed ac3c1d4
make web support hostinfo
BlockListed 6867099
make headers use hostinfo
BlockListed 2670db1
make accounts support multi-domains
BlockListed 81dd479
make ciphers work with multi-domains
BlockListed 3421dfc
make emergency access work with multi-domains
BlockListed ab96b26
make getting config work with multi-domains
BlockListed 901bf57
make organizations work with multi-domains
BlockListed df524c7
make PublicToken support multi-domains
BlockListed 7639a2b
make identity support multi-domains
BlockListed 1dfc68a
make auth support multi-domains
BlockListed f208630
fix issue in config
BlockListed c0db0d8
make clippy happy
BlockListed 3a66772
use single hashmap instead of two for domain lookups
BlockListed 12bdcd4
clippy and format
BlockListed fc78b6f
implement error handling for HostInfo extractor
BlockListed d627b02
remove admin_path function
BlockListed 96261f1
remove breaking parameter from to_json methods
BlockListed edcd264
cargo clippy and cargo fmt
BlockListed 09c0367
re-add domain_origin field to configuration
BlockListed 298cf8a
change back name of domain configuration option
BlockListed 335984e
cargo clippy and cargo fmt
BlockListed d1cb726
fix bug when extracing host from domain
BlockListed 6375a20
cargo clippy and cargo fmt
BlockListed aceaf61
switch back to admin_path, since cookies break otherwise
BlockListed fae770a
remove some outdated comments / move import
BlockListed c150818
rebase and fix rebase issues
BlockListed 158f834
Merge branch 'main' into multiple-domains-support
BlackDex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
replace domain with base_url
commit 17923c3fd0ca24a1d537c3e1e0d446f847ed0609
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have added several
log::
entries here.log::
can be removed since those macro's should be callable directly.But logging in this location could slow down the application a lot. Even though it only should do this during debug, it will do this for every call which will do something with that Struct.
If it is really needed to have this info here, i would then suggest to place it under
trace!
instead.