Optimized Favicon downloading #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-garcia
reviewed
Aug 12, 2023
BlackDex
force-pushed
the
optimize-icon-fetching
branch
from
f84714c to
824451b
Compare
dani-garcia
approved these changes
Aug 13, 2023
Some optimizations in regards to downloading Favicon's. I also encounterd some issues with accessing some sites where the connection got dropped or closed early. This seems a reqwest/hyper thingy, hyperium/hyper#2136. This is now also fixed. General: - Decreased struct size - Decreased memory allocations - Optimized tokenizer a bit more to only emit tags when all attributes are there and are valid. reqwest/hyper connection issue: The following changes helped solve the connection issues to some sites. The endresult is that some icons are now able to be downloaded always instead of sometimes. - Enabled some extra reqwest features, `deflate` and `native-tls-alpn` (Which do not bring in any extra crates since other crates already enabled them, but they were not active for Vaultwarden it self) - Configured reqwest to have a max amount of idle pool connections per host - Configured reqwest to timeout the idle connections in 10 seconds
BlackDex
force-pushed
the
optimize-icon-fetching
branch
from
824451b to
6cdcb3b
Compare
arthurgeek
referenced
this pull request
in arthurgeek/vaultwarden-fly-template
Sep 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | stage | patch | `1.29.1-alpine` -> `1.29.2-alpine` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.29.2`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.29.2) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.29.1...1.29.2) Minor release to fix an issue forcing user to set amaster password when logging in even when it's already set #### What's Changed - Fix .env.template file by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3734](https://togithub.com/dani-garcia/vaultwarden/pull/3734) - Fix UserOrg status during LDAP Import by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3740](https://togithub.com/dani-garcia/vaultwarden/pull/3740) - Update images to Bookworm and PQ15 and Rust v1.71 by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3573](https://togithub.com/dani-garcia/vaultwarden/pull/3573) - Implement "login with device" by [@​quexten](https://togithub.com/quexten) in [https://github.com/dani-garcia/vaultwarden/pull/3592](https://togithub.com/dani-garcia/vaultwarden/pull/3592) - chore: Bump web vault to v2023.7.1 and bump Rust by [@​GeekCornerGH](https://togithub.com/GeekCornerGH) in [https://github.com/dani-garcia/vaultwarden/pull/3769](https://togithub.com/dani-garcia/vaultwarden/pull/3769) - Optimized Favicon downloading by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3751](https://togithub.com/dani-garcia/vaultwarden/pull/3751) - add UserDecryptionOptions to login response by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3813](https://togithub.com/dani-garcia/vaultwarden/pull/3813) - add new secretsmanager plan for web-v2023.8.x by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3797](https://togithub.com/dani-garcia/vaultwarden/pull/3797) - Allow Authorization header for Web Sockets by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3806](https://togithub.com/dani-garcia/vaultwarden/pull/3806) - Update admin interface by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3730](https://togithub.com/dani-garcia/vaultwarden/pull/3730) **Full Changelog**: dani-garcia/vaultwarden@1.29.1...1.29.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
arthurgeek
referenced
this pull request
in arthurgeek/vaultwarden-fly
Sep 2, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | stage | patch | `1.29.1-alpine` -> `1.29.2-alpine` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.29.2`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.29.2) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.29.1...1.29.2) Minor release to fix an issue forcing user to set amaster password when logging in even when it's already set ##### What's Changed - Fix .env.template file by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3734](https://togithub.com/dani-garcia/vaultwarden/pull/3734) - Fix UserOrg status during LDAP Import by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3740](https://togithub.com/dani-garcia/vaultwarden/pull/3740) - Update images to Bookworm and PQ15 and Rust v1.71 by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3573](https://togithub.com/dani-garcia/vaultwarden/pull/3573) - Implement "login with device" by [@​quexten](https://togithub.com/quexten) in [https://github.com/dani-garcia/vaultwarden/pull/3592](https://togithub.com/dani-garcia/vaultwarden/pull/3592) - chore: Bump web vault to v2023.7.1 and bump Rust by [@​GeekCornerGH](https://togithub.com/GeekCornerGH) in [https://github.com/dani-garcia/vaultwarden/pull/3769](https://togithub.com/dani-garcia/vaultwarden/pull/3769) - Optimized Favicon downloading by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3751](https://togithub.com/dani-garcia/vaultwarden/pull/3751) - add UserDecryptionOptions to login response by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3813](https://togithub.com/dani-garcia/vaultwarden/pull/3813) - add new secretsmanager plan for web-v2023.8.x by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3797](https://togithub.com/dani-garcia/vaultwarden/pull/3797) - Allow Authorization header for Web Sockets by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3806](https://togithub.com/dani-garcia/vaultwarden/pull/3806) - Update admin interface by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3730](https://togithub.com/dani-garcia/vaultwarden/pull/3730) **Full Changelog**: dani-garcia/vaultwarden@1.29.1...1.29.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optimizations in regards to downloading Favicon's.
I also encounterd some issues with accessing some sites where the connection got dropped or closed early. This seems a reqwest/hyper thingy, hyperium/hyper#2136. This is now also fixed.
General:
reqwest/hyper connection issue:
The following changes helped solve the connection issues to some sites. The endresult is that some icons are now able to be downloaded always instead of sometimes.
deflateandnative-tls-alpn(Which do not bring in any extra crates since other crates already enabled them, but they were not active for Vaultwarden it self)