Run mobile push requests in background #3579
Closed
+146
−100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another partial fix for #3577.
Combining this with PR #3578, this should solve #3577.
Mobile push requests are currently run blocking within the HTTP Put for updating a cipher request. In the Bitwarden UI this just shows as if updating the entry takes up to multiple seconds. This request moves the actual HTTP request to the Bitwarden Push servers into a tokio task. This way, sending the notifications does not block the request to update a cipher.