WebSockets via Rocket's Upgrade connection

[BlackDex]

This PR implements a (not yet fully released) new feature of Rocket which allows WebSockets/Upgrade connections.
No more need for multiple ports to be opened for Vaultwarden.
No explicit need for a reverse proxy to get WebSockets to work (Although I still suggest to use a reverse proxy).

• Using a git revision for Rocket, since rocket_ws is not yet released.
• Updated other crates as well.
• Added a connection guard to clear the WS connection from the Users list.

Fixes #685
Fixes #2917
Fixes #1424

[BlackDex]

I think the implementation is working. It can use both port 3012 Direct Tungstenite and the Rocket/Tungstenite implementation.
It can be mixed and notification will be sent to both.

Best would be if Rocket 0.5 would be released as stable so that we do not have to use a patched version.

[dani-garcia]

Looks good to me, do we want to wait until there's a stable release or a release candidate or should we just merge and allow it to be tested on the testing images?

[BlackDex]

@dani-garcia , i think for testing it's fine.
Not sure if we want to release a .2 soon with some fixes currently merged? I do have a fix pending on my laptop regarding some admin interface fixes which were caused by the recent updates.

[dani-garcia]

True, I don't expect this change to break anything, and we still have the 3012 fallback anyway.

[BlackDex]

Just as a note here for now.

If you want to use this, you still need to make sure that your reverse proxy pass-through the upgrade request correctly.

For nginx you can use the following.

Somewhere within the http {}

map $http_upgrade $connection_upgrade {
    default upgrade;
    ''      "";
}

And then within the location.

location / {
  proxy_http_version 1.1;
  proxy_set_header Upgrade $http_upgrade;
  proxy_set_header Connection $connection_upgrade;

[qymab]

With this change (WebSocket notifications now work via the default HTTP port ) should I remove this line from my docker compose :

- traefik.http.routers.bwws.middlewares=redirect-to-https
- traefik.http.routers.bwws.service=bw-ws
- traefik.http.services.bw-ws.loadbalancer.server.port=3012

thanks