Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version missing from logs #4150

Closed
dfunkt opened this issue Dec 9, 2023 · 1 comment · Fixed by #4153
Closed

Version missing from logs #4150

dfunkt opened this issue Dec 9, 2023 · 1 comment · Fixed by #4153
Labels
bug Something isn't working

Comments

@dfunkt
Copy link
Contributor

dfunkt commented Dec 9, 2023

Subject of the issue

Version missing

Deployment environment

  • vaultwarden version:
    Latest one built after commit 8ab2002
  • Install method:
    testing-alpine tag via docker compose

Steps to reproduce

  1. Start Vaultwarden
  2. Check logs

Expected behaviour

Show version number with the latest commit from build time

Actual behaviour

Only "Starting Vaultwarden" shows up

Troubleshooting data

vaultwarden  | /--------------------------------------------------------------------\
vaultwarden  | |                        Starting Vaultwarden
    |
vaultwarden  | |--------------------------------------------------------------------|
vaultwarden  | | This is an *unofficial* Bitwarden implementation, DO NOT use the   |
vaultwarden  | | official channels to report bugs/features, regardless of client.   |
vaultwarden  | | Send usage/configuration questions or feature requests to:
    |
vaultwarden  | |   https://github.com/dani-garcia/vaultwarden/discussions or
    |
vaultwarden  | |   https://vaultwarden.discourse.group/
    |
vaultwarden  | | Report suspected bugs/issues in the software itself at:
    |
vaultwarden  | |   https://github.com/dani-garcia/vaultwarden/issues/new
    |
vaultwarden  | \--------------------------------------------------------------------/
vaultwarden  |
@BlackDex BlackDex added the bug Something isn't working label Dec 9, 2023
@BlackDex
Copy link
Collaborator

BlackDex commented Dec 9, 2023

Strange indeed. Need to look into this.

BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Dec 9, 2023
@BlackDex
Fix the version string
9494584 
For some reason still not known, the `.git` directory was not copied
into the container. I think buildkit (buildx) did this by default before, and
stopped this with newer versions.

This PR fixes this by adding a `COPY` for the `.git` directory.

This PR also updates Rust to v1.74.1 and some crates, including the
latest version of Alpine 3.19.

Fixes dani-garcia#4150
@BlackDex BlackDex mentioned this issue Dec 9, 2023
Merged
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Dec 9, 2023
@BlackDex
Fix the version string
f0d0a03 
For some reason still not known, the `.git` directory was not copied
into the container. I think buildkit (buildx) did this by default before, and
stopped this with newer versions.

This PR fixes this by also touching `build.rs` besides `src/main.rs`.

This PR also updates Rust to v1.74.1 and some crates, including the
latest version of Alpine 3.19.

Fixes dani-garcia#4150
dani-garcia pushed a commit that referenced this issue Dec 9, 2023
@BlackDex
Fix the version string (#4153)
3246251 
For some reason still not known, the `.git` directory was not copied
into the container. I think buildkit (buildx) did this by default before, and
stopped this with newer versions.

This PR fixes this by also touching `build.rs` besides `src/main.rs`.

This PR also updates Rust to v1.74.1 and some crates, including the
latest version of Alpine 3.19.

Fixes #4150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the version string BlackDex/vaultwarden
2 participants
@BlackDex @dfunkt