api::core::ciphers::put_cipher_share_selected does not use cipher_ids

[zacknewman]

This may not be a bug, but it could be if cipher_ids is actually important. Anyway, cipher_ids in api::core::ciphers::put_cipher_share_selected is never read from. Is this accidental? What's the point of pushing IDs into it without ever reading the IDs?

Possible fix if that variable is unimportant:

#[put("/ciphers/share", data = "<data>")]
async fn put_cipher_share_selected(
    data: JsonUpcase<ShareSelectedCipherData>,
    headers: Headers,
    mut conn: DbConn,
    nt: Notify<'_>,
) -> EmptyResult {
    let mut data: ShareSelectedCipherData = data.into_inner().data;

    if data.Ciphers.is_empty() {
        err!("You must select at least one cipher.")
    }

    if data.CollectionIds.is_empty() {
        err!("You must select at least one collection.")
    }

    for cipher in data.Ciphers.iter() {
        if cipher.Id.is_none() {
            err!("Request missing ids field");
        }
    }

    while let Some(cipher) = data.Ciphers.pop() {
        let mut shared_cipher_data = ShareCipherData {
            Cipher: cipher,
            CollectionIds: data.CollectionIds.clone(),
        };

        match shared_cipher_data.Cipher.Id.take() {
            Some(id) => share_cipher_by_uuid(&id, shared_cipher_data, &headers, &mut conn, &nt).await?,
            None => err!("Request missing ids field"),
        };
    }
    Ok(())
}

[BlackDex]

Looks like a leftover indeed. I'll check it out further but i think you are right.

[BlackDex]

btw strange that clippy doesn't find this. It should see that it's never read after written.

[zacknewman]

clippy::nursery (https://rust-lang.github.io/rust-clippy/master/index.html#/collection_is_never_read?groups=nursery) contains the necessary lint. On my personal fork of Vaultwarden, I deny all lints and allow specific lints (e.g., implicit_return), and it has helped me clean up some stuff including detecting the &mut DbConn I mentioned earlier. #![deny(unsafe_code, unused, warnings, clippy::all,    clippy::cargo, clippy::complexity, clippy::correctness, clippy::nursery, clippy::pedantic, clippy::perf, clippy::restriction, clippy::style, clippy::suspicious)]