Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue importing JSON to vaultwarden web #4005

Closed
obnoxiousmods opened this issue Oct 27, 2023 · 9 comments · Fixed by #4030
Closed

Issue importing JSON to vaultwarden web #4005

obnoxiousmods opened this issue Oct 27, 2023 · 9 comments · Fixed by #4030

Comments

@obnoxiousmods
Copy link

obnoxiousmods commented Oct 27, 2023

Imported .JSON file that was exported from my bitwarden for windows into vaultwarden web,

Expected Result: a successful import

WHAT ACTUALLY HAPPENS ERROR: e.match was null (or == null idr)

Must be a bug as I exported .csv from bitwarden for windows then imported and it worked fine.

Thanks <3(i just cloned the repos now so must be newest version)

@BlackDex
Copy link
Collaborator

There is nothing done on the server side in regards of reading any import file from any type.
The conversion is done by the client which then reads, converts and encrypts the imported data and then sends that to the server.

So, if you think this is a server side issue, there must be something in the error logs of Vaultwarden, but i think this is probably a web-vault issue which is not something we develop.

@obnoxiousmods
Copy link
Author

There is nothing done on the server side in regards of reading any import file from any type. The conversion is done by the client which then reads, converts and encrypts the imported data and then sends that to the server.

So, if you think this is a server side issue, there must be something in the error logs of Vaultwarden, but i think this is probably a web-vault issue which is not something we develop.

I suppose I thought it would be related to the patchs applied to web-vault, as it seemed unlikely the official one has broken JSON importing, I suppose Ill open a ticket in web-vault's git and vaultwarden web vault patched repo

@BlackDex
Copy link
Collaborator

Ok, but what do the logs say of Vaultwarden, there probably must have been an error there for this to cause such a message if it is coming from Vaultwarden.

@dfunkt
Copy link
Contributor

dfunkt commented Oct 27, 2023

This is what I get when I try to import my encrypted json (password protected) to an organization vault:
vaultwarden | [2023-10-27 12:19:37.398][vaultwarden::api::core::ciphers][ERROR] The client copy of this cipher is out of date. Resync the client and try again.
Dozens, if not hundreds, of messages like this ^^

@BlackDex
Copy link
Collaborator

Thx! We might be able to track down what the issue is now.

@dfunkt
Copy link
Contributor

dfunkt commented Nov 4, 2023

Still having this issue when using the latest testing build (Version 1.29.2-93da5091, testing-alpine)

@BlackDex
Copy link
Collaborator

BlackDex commented Nov 4, 2023

That's because it isn't fixed yet. Only the new web-vault and passkeys are changed after your last try.

@dfunkt
Copy link
Contributor

dfunkt commented Nov 4, 2023

Yeah, I only mentioned it because I thought that maybe the new web-vault would fix the issue.

@BlackDex
Copy link
Collaborator

BlackDex commented Nov 4, 2023

That could have been the case, but I think it's more a server side item. I already checked it, have to work on a fix.

BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Nov 5, 2023
When importing Bitwarden JSON exports, these would fail because the last
modification date was also imported and caused our out-off-sync check to
kick-in. This PR fixes this by checking if we are doing an import, and
skip this check.

Fixes dani-garcia#4005
dani-garcia pushed a commit that referenced this issue Nov 5, 2023
When importing Bitwarden JSON exports, these would fail because the last
modification date was also imported and caused our out-off-sync check to
kick-in. This PR fixes this by checking if we are doing an import, and
skip this check.

Fixes #4005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants