Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live sync for organization items only working when not using roles / groups #3413

Closed
wucherpfennig opened this issue Apr 3, 2023 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed low priority Won't fix anytime soon, but will accept PR if provided troubleshooting There might be bug or it could be user error, more info needed

Comments

@wucherpfennig
Copy link

wucherpfennig commented Apr 3, 2023

Subject of the issue

  • live sync for organization items does not work if you are using roles / groups.
  • live sync does not work if you are adding members via group to a collection
  • live sync works only if you are adding a member directly to a collection

Deployment environment

  • vaultwarden version: 1.28.1-alpine
  • Install method: docker
  • Clients used: all (tested: Windows Desktop, Browser, Firefox, Chrome)
  • Reverse proxy and version: traefik-2.9.9
  • MySQL/MariaDB or PostgreSQL version: 8.X
  • Other relevant details: websocket works as without using groups everything runs as expected

Steps to reproduce

  1. Create an organisation
  2. Create a collection
  3. Create a group
  4. Create two test accounts
  5. assign one account to the group (3) and then the group (3) to the collection (2)
  6. assign one account directly to the collection (2)
  7. add / update / delete items in the collection (2)

Result

  • account from 5: will only see the changes via reload
  • account from 6: will see the changes immediately

Expected behaviour

Live sync all the items to all the group members not only to the "hardcoded" directly assigned collection members.

Actual behaviour

Changes from organization members (independent whether using groups or not) will be reflected immediately to the organization owner but if the owner / somebody else creates a new entry in the collection this change will only be available after a "hard" reload (ctrl+shift+r).

This issue is resolved by no using groups! By not using them everything works as expected.

BR wucherpfennig

@BlackDex BlackDex added the troubleshooting There might be bug or it could be user error, more info needed label Apr 3, 2023
@BlackDex
Copy link
Collaborator

BlackDex commented Apr 3, 2023

Thanks for the report.
I want to note that groups is still an experimental feature. But we do need reports like this to make it better.

@wucherpfennig
Copy link
Author

We are very much aware of that "experimental" state but to be honest until now everything else works great and it saves us a lot of time managing our accounts and collections. 👍🏻

@BlackDex
Copy link
Collaborator

BlackDex commented Apr 3, 2023

Good to hear 😄 . It's probably a query which needs some extra joins (which i do not like)

@BlackDex BlackDex added the help wanted Extra attention is needed label Apr 30, 2023
@BlackDex BlackDex added the bug Something isn't working label Jul 12, 2023
@BlackDex BlackDex added the low priority Won't fix anytime soon, but will accept PR if provided label Jul 12, 2023
@ghunti
Copy link

ghunti commented Jul 20, 2023

I have the same issue running 1.29.0

@BlackDex
Copy link
Collaborator

I have the same issue running 1.29.0

Which is logical, since the issue is still open ;)

@xKugeki
Copy link

xKugeki commented Aug 1, 2023

Are there any new information about bug fixing this problem ^^?
Or workarounds with groups enabled + Live Sync :)

@BlackDex
Copy link
Collaborator

BlackDex commented Aug 1, 2023

Not from my part yet. I have not found the time or will to try and tackle this specific issue.
I have some ideas to try and use sub-select queries to maybe tackle this in a bit nice way instead of creating complex joins.
But not yet started on it. So if somebody else finds this an interesting item to pickup, please do not hesitate, there is a help-wanted label there for a reason ;)

matlink added a commit to matlink/vaultwarden that referenced this issue Aug 5, 2023
BlackDex pushed a commit to matlink/vaultwarden that referenced this issue Oct 24, 2023
BlackDex pushed a commit to matlink/vaultwarden that referenced this issue Dec 31, 2023
lumpsoid pushed a commit to lumpsoid/vaultwarden that referenced this issue Jan 14, 2024
…roups (dani-garcia#3757)

* Fix dani-garcia#3413: push to users acessing the collections using groups

* Notify groups only when enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed low priority Won't fix anytime soon, but will accept PR if provided troubleshooting There might be bug or it could be user error, more info needed
Projects
None yet
Development

No branches or pull requests

4 participants