optimize condition check

dani-garcia · Aug 5, 2023 · 930adb8 · 930adb8
1 parent d282b32
commit 930adb8
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/api/core/organizations.rs b/src/api/core/organizations.rs
@@ -358,12 +358,13 @@ async fn get_org_collections_details(org_id: &str, headers: ManagerHeadersLoose,
             })
             .collect();
 
-        // if current user is in any collection-assigned group or in a group having access to all collections
-        if group_users.contains(&user_org.uuid) || all_access_group_uuids.contains(&user_org.uuid) {
-            assigned = true;
-        }
-
-        if user_org.access_all {
+        // if current user is in any collection-assigned group
+        // or in a group having access to all collections
+        // or itself has access to all collections
+        if group_users.contains(&user_org.uuid)
+            || all_access_group_uuids.contains(&user_org.uuid)
+            || user_org.access_all
+        {
             assigned = true;
         }