Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tagging behavior when package content does not change #31

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tobalsan
Copy link

@tobalsan tobalsan commented Sep 9, 2022

This avoids pushing "empty" tags to split repositories when their content did not change. This mimics the Symfony monorepo behavior, as it applies only to patch versions, e.g. 2.3.1. For minor and major versions, new tags are still pushed to split repositories, whether they contain changes or not.

In effect, here's the behavior to expect for a split package inside a monorepo:

  • when you push to the monorepo a new tag
    • and the target package has bee updated
      • the new tag is pushed
    • the target package has no change, and the tag is a patch version (e.g. 2.3.1)
      • nothing happens (the tag is skipped in the split repository)
    • the target package has no change, and the tag is a minor or major version (e.g. 2.4 or 3.0)
      → the new tag is pushed to the split repository

Thinh Dinh and others added 5 commits September 9, 2022 23:31
This avoids pushing "empty" tags to split repositories when their content did not change.
This mimics the Symfony monorepo behavior, as it applies only to patch versions, e.g. 2.3.1.
For minor and major versions, new tags are still pushed to split repositories, whether they contain changes or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants