Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark body as nullable for Github PRs #1186

Closed
wants to merge 1 commit into from
Closed

fix: mark body as nullable for Github PRs #1186

wants to merge 1 commit into from

Conversation

G-Rath
Copy link

@G-Rath G-Rath commented Dec 26, 2021

Resolves #1185

@G-Rath
Copy link
Author

G-Rath commented Dec 27, 2021

Looks like CI has failed due to unrelated reasons:

image

@fbartho
Copy link
Member

fbartho commented Jan 6, 2022

This is blocked by #1189 or an alternative solution to the problem!

@orta
Copy link
Member

orta commented Jan 7, 2022

I'm also not sure it's something I want to merge on reflection, I think this is a purposeful choice to make life easier for writing dangerfiles

@G-Rath
Copy link
Author

G-Rath commented Jan 7, 2022

@orta personally I think if it's possible Danger should normalise this so that it's always a string.

However, in saying that as of right now currently the types are wrong since it is possible for this value to be null which this fixes - so depending on how long it might take to implement ensuring this property is always a string, I think it might still be worth merging this first.

@orta
Copy link
Member

orta commented Jan 7, 2022

Good point, just shipped #1191 while waiting on CI 👍🏻

Thanks for getting this moving @G-Rath

@orta orta closed this Jan 7, 2022
@G-Rath G-Rath deleted the patch-1 branch January 7, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Body can apparently be null
3 participants