Use full unformatted subject message

[denieler]

We want to use danger js locally to check the format of conventional commits for the commit messages. Due to that, we need to have a full unformatted subject line. Similar issue is explained in #977

[orta]

This will probably need additional work - message is used to ensure it is a single line because it is serialized to JSON right after.

[denieler]

hey @orta 👋

This will probably need additional work - message is used to ensure it is a single line because it is serialized to JSON right after.

Tested the change and it looks like it works fine. Change %f to %s only changes formatting but left only a single line of the commit message (https://git-scm.com/docs/pretty-formats#Documentation/pretty-formats.txt-emsem, it takes only subject).

I've tried to find a good place to add tests for this functionality but didn't find, also it looks a bit tricky to test git log output 😞 if you have any suggestions - please share.

And travis pr check is failing with some "Bad credentials message". Not sure that this change could cause it 😞

Please help 😃

[denieler]

hey @orta 👋 any news? can we merge this PR?

[orta]

Remember I do this in my spare time.

Can you verify that having " in a commit message won't break with this change? You can ignore the red CI from travis, I still need to get that fixed

[denieler]

@orta sure, checking...

[denieler]

hey @orta! It appeared that previous implementation does not respect " or any other quotes 😃 After some research I found that it's fairly hard to do that via git log which was there before and requires some extra work, so found gitlog package - it provides what's necessary. Just had to shape it to the current usage 👍 Looks like now working fine. Please check.

P.S. Had to update typescript, because the new library using new types, which are supported in TS 3.8, but in Danger it was super outdated (3.1.1). And another change was because of that. But looks like it doesn't break anything.

[denieler]

because TS was updated it started to complain about

So had to fix this type to fix it

[denieler]

hey @orta ! Can you please review this PR? 🙇

[orta]

I'm not a fan of adding new dependencies to Danger JS and I don't think this is worth it.

I'll take reverting back to 6a17936 and accept that 👍🏻

[denieler]

@orta what do you think if I copy partially the part from the gitlog package into dangerjs code? Do you think this will be a better solution?

[orta]

Maybe, kinda depends on how much code it is - given the goal is to import a string, switching " -> "▍" (some random char) before putting it into the JSON and flipping it on the other side would also solve the problem too.

[denieler]

Maybe, kinda depends on how much code it is - given the goal is to import a string, switching " -> "▍" (some random char) before putting it into the JSON and flipping it on the other side would also solve the problem too.

There are few characters, which can affect JSON.parse, so I didn't really want to move this way. Ok, let me make a change and I will ping you one more time. If you don't like it - we can go with string.replace for a bunch of special characters

[denieler]

@orta please take a look at the new change. I've not rolled back the typescript update, because it looks for me like a healthy dependency update for the library and it looks like not breaking anything

[orta]

Looks great to me, let's get this shipped

[glensc]

the included gitlog is BSD-3-Clause licensed, meaning you must preserve any copyright notices, which is not done here.

read the license here:

• https://opensource.org/licenses/BSD-3-Clause

the file in question:

• https://github.com/denieler/danger-js/blob/040d5a374f74e5cf185d182397570e539adbbc18/source/platforms/git/localLogGitCommits.ts