Ensures that the Gitlab API is exposed properly through the dts

.github/workflows/CI.yml

@@ -10,9 +10,20 @@ jobs:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v1
 
-      # Get local dependencies
+      # Get local dependencies & test
       - run: yarn install
       - run: yarn build
+      - run: yarn test
+
+      # Validate related tooling
+      - run: yarn declarations
+      - run: yarn tsc distribution/danger.d.ts
+      - run: rm -rf node_modules/@types/babel-*
+      - run: rm -rf node_modules/@types/babylon
+      - run: echo "Testing Flow definition file"
+      - run: yarn build:flow-types
+      - run: yarn flow check
+
 
       - run: 'echo "This is only for Integration tests on two blank projects"'
 

scripts/danger-dts.ts

@@ -13,6 +13,7 @@ const createDTS = () => {
 //
 
 import { Octokit as GitHub } from "@octokit/rest"
+import { Gitlab } from "gitlab"
 
 `
   const footer = ``

source/danger.d.ts

@@ -3,6 +3,7 @@
 //
 
 import { Octokit as GitHub } from "@octokit/rest"
+import { Gitlab } from "gitlab"
 
 type MarkdownString = string
 // TODO: extract out from BitBucket specifically, or create our own type
@@ -1455,7 +1456,7 @@ interface GitLabDSL extends GitLabJSONDSL {
   utils: {
     fileContents(path: string, repoSlug?: string, ref?: string): Promise<string>
   }
-  api: GitLabAPI
+  api: InstanceType<typeof Gitlab>
 }
 
 // ---

source/dsl/GitLabDSL.ts

@@ -1,7 +1,7 @@
 // Please don't have includes in here that aren't inside the DSL folder, or the d.ts/flow defs break
 
 // TODO: extract out from BitBucket specifically, or create our own type
-import GitLabAPI from "../platforms/gitlab/GitLabAPI"
+import { Gitlab } from "gitlab"
 import { RepoMetaData } from "./BitBucketServerDSL"
 
 // getPlatformReviewDSLRepresentation
@@ -22,7 +22,7 @@ export interface GitLabDSL extends GitLabJSONDSL {
   utils: {
     fileContents(path: string, repoSlug?: string, ref?: string): Promise<string>
   }
-  api: GitLabAPI
+  api: InstanceType<typeof Gitlab>
 }
 
 // ---

source/platforms/GitLab.ts

@@ -193,5 +193,5 @@ export const gitlabJSONToGitLabDSL = (gl: GitLabDSL, api: GitLabAPI): GitLabDSL
   utils: {
     fileContents: api.getFileContents,
   },
-  api,
+  api: api.apiInstance,
 })

source/platforms/gitlab/GitLabAPI.ts

@@ -75,6 +75,10 @@ class GitLabAPI {
     return `${this.projectURL}/merge_requests/${this.repoMetadata.pullRequestID}`
   }
 
+  get apiInstance() {
+    return this.api
+  }
+
   getUser = async (): Promise<GitLabUserProfile> => {
     this.d("getUser")
     const user = (await this.api.Users.current()) as GitLabUserProfile