Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add img registration #729

Closed
wants to merge 31 commits into from
Closed

Add img registration #729

wants to merge 31 commits into from

Conversation

DannieSheng
Copy link
Contributor

Describe your changes
Add img_registration function that is capable of collecting (interactive framework) user-clicked points on reference and target image and align two images

Type of update
Is this a:

  • New feature or feature enhancement
  • Update to documentation
  • Work in progress

Associated issues
#715

@DannieSheng DannieSheng added new feature New feature ideas and solutions work in progress Mark work in progress labels Mar 19, 2021
@DannieSheng DannieSheng added this to the PlantCV v4.x milestone Mar 19, 2021
@DannieSheng DannieSheng self-assigned this Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #729 (842a90a) into 4.x (bf4e52b) will decrease coverage by 0.62%.
The diff coverage is 49.39%.

❗ Current head 842a90a differs from pull request most recent head 5a93d0d. Consider uploading reports for the commit 5a93d0d to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##               4.x     #729      +/-   ##
===========================================
- Coverage   100.00%   99.37%   -0.63%     
===========================================
  Files          159      159              
  Lines         6725     6756      +31     
===========================================
- Hits          6725     6714      -11     
- Misses           0       42      +42     
Flag Coverage Δ
unittests 99.37% <49.39%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/annotate/img_registration.py 23.63% <23.63%> (ø)
plantcv/plantcv/annotate/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/transform/warp.py 100.00% <100.00%> (ø)
plantcv/plantcv/crop.py 100.00% <0.00%> (ø)
plantcv/learn/naive_bayes.py 100.00% <0.00%> (ø)
plantcv/plantcv/plot_image.py 100.00% <0.00%> (ø)
plantcv/plantcv/roi/roi2mask.py 100.00% <0.00%> (ø)
plantcv/plantcv/roi/roi_methods.py 100.00% <0.00%> (ø)
plantcv/plantcv/morphology/prune.py 100.00% <0.00%> (ø)
plantcv/plantcv/morphology/find_tips.py 100.00% <0.00%> (ø)
... and 15 more

@DannieSheng DannieSheng force-pushed the add_img_registration branch from 2c7f538 to 5fc1ea4 Compare June 16, 2021 17:56
@DannieSheng DannieSheng added ready to review and removed work in progress Mark work in progress labels Jun 25, 2021
@HaleySchuhl HaleySchuhl self-requested a review August 24, 2021 16:05
nfahlgren
nfahlgren previously approved these changes Dec 17, 2021
Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor to utilize the new annotate subpackage

@nfahlgren nfahlgren dismissed their stale review December 17, 2021 17:25

Accidentally approved, meant to request changes

Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor to utilize the new annotate subpackages

@HaleySchuhl HaleySchuhl added work in progress Mark work in progress and removed ready to review labels Dec 20, 2021
@HaleySchuhl
Copy link
Contributor

Archiving for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature ideas and solutions work in progress Mark work in progress
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants