-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warning about label
from the detect color card function
#1664
Open
HaleySchuhl
wants to merge
13
commits into
main
Choose a base branch
from
remove_label_detect_color_card
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaleySchuhl
added
bugfix
Bug fixes
ready to review
update
Updates an existing feature/method
cleanup
Code quality updates
labels
Jan 23, 2025
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
HaleySchuhl
added
work in progress
Mark work in progress
and removed
ready to review
labels
Jan 24, 2025
HaleySchuhl
added
ready to review
and removed
work in progress
Mark work in progress
labels
Jan 24, 2025
Add space in warning for clarity.
Add space in warning for clarity.
k034b363
approved these changes
Jan 27, 2025
HaleySchuhl
changed the title
Remove
Add deprecation warning about Jan 28, 2025
label
from the detect color card functionlabel
from the detect color card function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Bug fixes
cleanup
Code quality updates
ready to review
update
Updates an existing feature/method
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a deprecation warning that we plan to remove the
label
parameter input fromdetect_color_card
andauto_correct_color
(since the trait of chip size is now a metadata term and therefore doesn't utilize a label).Type of update
Is this a:
Associated issues
Additional context
Technically a breaking change compared to before the chip size was converted to a metadata term.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md