-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove label
parameter from pcv.transform.detect_color_card
and auto_correct_color
in v5.0
#1660
Comments
@all-contributors please add @eseigeldanf for bug, tutorial, documentation @all-contributors please add @trogers623 for tutorial, documentation @all-contributors please add @Sunitalama2 for tutorial, documentation |
I've put up a pull request to add @eseigeldanf! 🎉 |
@all-contributors please add @trogers623 for tutorial, documentation |
I've put up a pull request to add @trogers623! 🎉 |
@all-contributors please add @Sunitalama2 for tutorial, documentation |
I've put up a pull request to add @Sunitalama2! 🎉 |
Doing these one at a time now, thanks to the new contributors 👏 @all-contributors please add @Sunitalama2 for tutorial, documentation |
@Sunitalama2 already contributed before to tutorial, doc |
@all-contributors please add @clhendrikse for tutorial, documentation |
I've put up a pull request to add @clhendrikse! 🎉 |
label
parameter from pcv.transform.detect_color_card
and auto_correct_color
label
parameter from pcv.transform.detect_color_card
and auto_correct_color
in v5.0
Describe the bug
Remove unused
label
parameter frompcv.transform.detect_color_card
andauto_correct_color
. Since this is a breaking change, add to v5.0 release.To Reproduce
Old color correction tutorial breaks when used with v4.6
Expected behavior
No unused inputs, so remove from the function and reflect this change in documentation page. Show the new syntax for calling color chip size now that it is a metadata term (per image) and not an observation (per object).
Additional context
The reason we didn't realize the
label
parameter is never used is because it's techincally getting used just from us checking whether it isNone
or not.Thanks to @eseigeldanf for bringing this bug to our attention while updating tutorials.
The text was updated successfully, but these errors were encountered: