Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memory usage logging #154

Closed
jwodder opened this issue Jul 9, 2024 · 4 comments · Fixed by #234
Closed

Remove memory usage logging #154

jwodder opened this issue Jul 9, 2024 · 4 comments · Fixed by #234
Assignees
Labels
high priority Work on these first performance Efficient use of time and space

Comments

@jwodder
Copy link
Member

jwodder commented Jul 9, 2024

As noted here, the functionality for logging memory usage before & after each request causes request processing to slow down by an order of magnitude. This functionality should be removed (or at least put behind a non-default feature) once #118 is resolved.

@jwodder jwodder added performance Efficient use of time and space blocked Cannot be implemented until something else happens labels Jul 9, 2024
@jwodder jwodder added this to the Current priorities milestone Jul 9, 2024
@jwodder jwodder self-assigned this Jul 11, 2024
@jwodder jwodder added the high priority Work on these first label Jul 22, 2024
@jwodder jwodder removed this from the Current priorities milestone Jul 22, 2024
@jwodder
Copy link
Member Author

jwodder commented Jan 23, 2025

@yarikoptic Can I do this now that #118 is resolved?

@yarikoptic
Copy link
Member

yeah, let's do that I guess since we assume it was addressed. There is no easy way to make it "optional" (compile or run time) while avoiding impact? This way we would be able to quickly turn it on to troubleshoot if it would come needed

@jwodder
Copy link
Member Author

jwodder commented Jan 24, 2025

@yarikoptic It could be made optional at either runtime or compile time; which do you prefer?

@jwodder jwodder removed the blocked Cannot be implemented until something else happens label Jan 24, 2025
@yarikoptic
Copy link
Member

it is up to you since you would be the most likely "user" ;-) "runtime" sounds better to me, if doesn't entail any runtime performance hit.

jwodder added a commit that referenced this issue Jan 27, 2025
Make memory-logging optional (off by default)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Work on these first performance Efficient use of time and space
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants