ci: release apple arm binary #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to fix this. |
MarcoIeni
commented
Nov 27, 2022
|
|
||
| steps: | ||
| - name: Installing Rust toolchain | ||
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: stable | ||
| target: ${{ matrix.job.target }} |
There was a problem hiding this comment.
This installs the target if missing. Useful for aarch64-apple-darwin on mac
|
This is ready now. 👍 |
|
Hi @MarcoIeni, thanks for this work! So basically, we add I've merged your reformatting PR so I'll wait for you to rebase this one. |
Yes, exactly |
|
Thank you very much @MarcoIeni! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested here
There are no VMs for GitHub actions that support Mac ARM. See actions/runner-images#2187.
So we cannot run tests for MAC ARM. However, we can run
cargo build, which is what's required to build the binary.