Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable UART before MMU enabled on aarch64 #17

Merged
merged 2 commits into from
Feb 5, 2023
Merged

Enable UART before MMU enabled on aarch64 #17

merged 2 commits into from
Feb 5, 2023

Conversation

gmacd
Copy link
Contributor

@gmacd gmacd commented Feb 4, 2023

  • Add early, non-locking console for use where atomics not available. This should be changed to the default locking console as soon as practical. Only used in aarch64 for now.
  • Use of early console is hidden from callers of println
  • Add MiniUART for raspberry pi
  • Add support for compressed aarch64 kernel

Signed-off-by: Graham MacDonald [email protected]

gmacd added 2 commits February 4, 2023 10:08
@gmacd
Enable UART before MMU enabled on aarch64
91e4331 
- Add early, non-locking console for use where atomics not available.  This should be changed to the default locking console as soon as practical.  Only used in aarch64 for now.
- Use of early console is hidden from callers of println
- Add MiniUART for raspberry pi
- Add support for compressed aarch64 kernel

Signed-off-by: Graham MacDonald <[email protected]>
@gmacd
Fix test by using spin look instead of nop
602cbea 
Signed-off-by: Graham MacDonald <[email protected]>
dancrossnyc
dancrossnyc approved these changes Feb 5, 2023
View reviewed changes
Copy link
Owner

@dancrossnyc dancrossnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably just get paging and the MMU up from assembly code, which is what Plan 9 did, instead of duplicating the UART. Perhaps open an issue, and we check this in now, and revisit at some point?

@dancrossnyc dancrossnyc merged commit d8c7a94 into dancrossnyc:main Feb 5, 2023
@gmacd
Copy link
Contributor Author

gmacd commented Feb 5, 2023

I think we should probably just get paging and the MMU up from assembly code, which is what Plan 9 did, instead of duplicating the UART. Perhaps open an issue, and we check this in now, and revisit at some point?

Makes sense

@gmacd gmacd deleted the raspi3 branch February 5, 2023 19:30
@gmacd gmacd mentioned this pull request Feb 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancrossnyc dancrossnyc dancrossnyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmacd @dancrossnyc