-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect size in header when using custom chunks #50
Comments
Hi @rkat, I'm sorry about this bug. It looks like you put together a good fix. Do you have time to submit a pull request? I think that you are only missing a unit test. If not, I will base a fix on the code that you supplied the next chance that I have. Thanks for the bug report! |
No worries, I'll add a unit test and make a pull request :) |
rjkat
added a commit
to rjkat/WAV.jl
that referenced
this issue
Nov 28, 2017
dancasimiro
added a commit
that referenced
this issue
Dec 3, 2017
fix issue #50 (incorrect header size when using custom chunks)
Fixed in v0.9.0 |
Awesome, thanks Dan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
wavwrite
, the length of the data chunk is used for both the header and the data chunk size.This results in an incorrect size in the header in the case where custom chunks have been supplied.
The fix looks something like this:
Thanks for your work on this package, it's fantastic 👍
The text was updated successfully, but these errors were encountered: