Add GDS to JSON/ YAML/ TOML Conversion CLI #35
Conversation
|
Nice. Meta point: I wonder, is there a more memorable name for this tool?
(Even something like Not a blocker. |
| @@ -0,0 +1,2 @@ | |||
|
|
|||
| // FIXME: make this the shared part of Gds21 (De)Serialization CLIs | |||
There was a problem hiding this comment.
is this just a placeholder for a future file?
There was a problem hiding this comment.
Yep, that's right, and that ties into the binary-name.
I agree there should be (several) nicer names. E.g.
gds2jsongds2yamlgds2tomlgds2{one of those things you wrote above}
And wanted to share the implementation of the former. But (a) wanted to use this today, and (b) couldn't immediately figure out the combination of sharing-as-library and creating-binaries.
layout21converters/src/gds2ser.rs
Outdated
| match format { | ||
| "json" => Ok(SerializationFormat::Json), | ||
| "yaml" => Ok(SerializationFormat::Yaml), | ||
| "toml" => Err(format!("TOML is not yet supported, see https://github.com/dan-fritchman/Layout21/issues/33").into()), |
There was a problem hiding this comment.
seems more straightforward to just make this do what it will have to eventually do when TOML is fixed, and then fix #33
There was a problem hiding this comment.
Definitely agree it's more straightforward.
Problem is the error you get when just allowing TOML to fail natively is less than ideal, as described in #33 and in toml-rs/toml#396
There was a problem hiding this comment.
Probably worth adding -
it's not entirely clear that #33 is actually fixable.
There was a problem hiding this comment.
I think gds2markup (not "markdown") seems probably the best name the multi-format program currently called gds2ser?
Prefer anything else?
…src/bin/, out of Cargo.toml. Rename => gds2markup.
…ers in the GDSII files.
|
Adds a total of four short CLI programs:
All four are (very) thin and use |
No description provided.