Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error msg in add command #110

Open
nus-pe-bot opened this issue Apr 20, 2021 · 3 comments
Open

Error msg in add command #110

nus-pe-bot opened this issue Apr 20, 2021 · 3 comments

Comments

@nus-pe-bot
Copy link

[destination: nus-tic4002-AY2021S2/pe-moderation assignee: boydanderson labels: response.Rejected severity.Low team.3 tutorial.TIC4002-F18 type.FunctionalityBug pending.0]

Summary of items to check:

Nothing to check :-)



Issue Description

When add a person with some missing information, e.g. no phone number or email address, app will displayed below error message.

Screenshot 2021-04-16 at 8.05.42 PM.png

However, if add phone number after the address, the app also allows to add the person.

Therefore, the add command do not have to follow the orders displayed in the error message. It makes the error message a bit redundant, it dose not tell user exactly what to do. For example, in this case, it should the phone number is missing rather than an invalid command format.


[original: Yiheng0410/pe#5]

Team's Response

Base on the user guide, the order of the information can be changed, and name, phone, email and address are necessary information that must be included.
Thus, this is not a bug.

To Check [0 Items]

Nothing to check :-)

@soc-se-bot-blue
Copy link

I noticed this too.

@damithc
Copy link
Owner

damithc commented Jun 18, 2023

When add a person with some missing information, e.g. no phone number or email address, app will displayed below error message.

Screenshot 2021-04-16 at 8.05.42 PM.png

Seems legit.

@soc-se-script
Copy link

Seems this issue is stale. Close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants