Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error msg in add command #5

Open
Yiheng0410 opened this issue Apr 16, 2021 · 1 comment
Open

Error msg in add command #5

Yiheng0410 opened this issue Apr 16, 2021 · 1 comment

Comments

@Yiheng0410
Copy link
Owner

Yiheng0410 commented Apr 16, 2021

When add a person with some missing information, e.g. no phone number or email address, app will displayed below error message.

Screenshot 2021-04-16 at 8.05.42 PM.png

However, if add phone number after the address, the app also allows to add the person.

Therefore, the add command do not have to follow the orders displayed in the error message. It makes the error message a bit redundant, it dose not tell user exactly what to do. For example, in this case, it should the phone number is missing rather than an invalid command format.

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 19, 2021

Team's Response

Base on the user guide, the order of the information can be changed, and name, phone, email and address are necessary information that must be included.
Thus, this is not a bug.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: Although mentioned in the UG, in the case where phone number is missing, will the error msg shown as phone number is missing better than a standard error msg?

User may not realised the phone number is missing when enter such a long command, dev team should also consider how user friendly the app could be when user is using the app.


Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants