Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check and update Circular Reference Resource Files test cases #330

Closed
damies13 opened this issue Jan 3, 2025 · 3 comments
Closed

check and update Circular Reference Resource Files test cases #330

damies13 opened this issue Jan 3, 2025 · 3 comments
Labels
potential bug Might be a bug, requires further clarification
Milestone
v1.5.0

Comments

@damies13
Copy link
Owner

damies13 commented Jan 3, 2025

Describe the bug
Check and update Circular Reference Resource Files test cases

  • seems like the test cases construct the path to the needed scenario but doesn't actually use it
  • lots of files test case needs review to make more reliable
    • add delay before start test
    • currently has delay in test plan but the agent might go into started state and not finish downloading files with current setup
@damies13 damies13 added the potential bug Might be a bug, requires further clarification label Jan 3, 2025
@damies13 damies13 added this to the v1.5.0 milestone Jan 3, 2025
@damies13
Copy link
Owner Author

damies13 commented Jan 3, 2025

No significant need to update the Circular Reference Resource Files test cases, the manager.ini file is generated by the test

image

Still need to try and fix the failures on lots of files test case

damies13 added a commit that referenced this issue Jan 4, 2025
@damies13
experiment with maximum thread count at 50
2a8c56f 
will need to set this to a multiple of cpu core count?
Issue #330
damies13 added a commit that referenced this issue Jan 4, 2025
@damies13
Use the same thread count method as the agent uses
a9db303 
and back to 5 minute wait on the test, maybe we can reduce this further?
Issue #330
damies13 added a commit that referenced this issue Jan 4, 2025
@damies13
Back to 10 min
b42c2fa 
- windows can't seem to copy all the files in 5 min
- also turned to thread count to debug 9
Issue #330
damies13 added a commit that referenced this issue Jan 5, 2025
@damies13
Try 7 minutes
31ec36e 
Issue #330
damies13 added a commit that referenced this issue Jan 5, 2025
@damies13
Back to 10 min, 7 was too short
bcf676b 
Issue #330
@damies13
Copy link
Owner Author

damies13 commented Jan 5, 2025

Found that sometimes there would be too many threads and would get an error about that, put in some code to limit the number of threads to 16 x cpu core count, and then found 5 minuets wasn't long enough for all files to be copied, so test now has 10 minute delay before starting and passes reliably now

@damies13
Copy link
Owner Author

damies13 commented Jan 5, 2025

Merged into 1.5 branch

@damies13 damies13 closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
potential bug Might be a bug, requires further clarification
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
1 participant
@damies13