Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate fields on plan screen before starting scenario #126

Closed
damies13 opened this issue Feb 5, 2023 · 1 comment
Closed

Validate fields on plan screen before starting scenario #126

damies13 opened this issue Feb 5, 2023 · 1 comment
Labels
enhancement New feature or request Manager Issue Affects the Manager
Milestone
v1.1.0

Comments

@damies13
Copy link
Owner

damies13 commented Feb 5, 2023

Is your feature request related to a problem? Please describe.
A few people have reported that rfswarm doesn't run anything when they miss selecting a test case from dropdown in the plan screen i've seen this in the discord chat and here in Issue #124

Describe the solution you'd like
Perform a validation of the fields on the plan screen when use clicks play before starting scenario, if a field is missed a dialogue should be presented to mention whats missing and test not started.

If possible also put a red ring around the fields that a missing data.
@damies13 damies13 added the enhancement New feature or request label Feb 5, 2023
@damies13 damies13 added this to the v1.1.0 milestone Mar 5, 2023
@damies13 damies13 added the Manager Issue Affects the Manager label Mar 5, 2023
damies13 added a commit that referenced this issue Mar 6, 2023
@damies13
First draft of field validation
fcae55a 
This puts in place the functions needed to trigger and return the validation results but doesn't actually do the validation yet, just putting this in before I forget it
Issue #126
damies13 added a commit that referenced this issue Mar 6, 2023
@damies13
Finish the validateion
a2ea404 
This should be everything we need to resolve Issue #126
damies13 added a commit that referenced this issue Mar 6, 2023
@damies13
Merge branch 'Issue-#126-Validate-fields' into v1.1.0
64807ac
@damies13
Copy link
Owner Author

damies13 commented Mar 6, 2023

Fix merged into v1.1.0 Release Branch

Example of the validation messages below:

Screenshot from 2023-03-06 18-51-24

@damies13 damies13 closed this as completed Mar 6, 2023
@damies13 damies13 mentioned this issue Apr 6, 2024
Closed
damies13 added a commit that referenced this issue Jul 19, 2024
@damies13
Merge pull request #266 from NiceProjectPoland/Test-#219-for-Issue-#126
5fcc855 
Test Cases for Issue #126 - Verify the field validation is working in the manager plan screen
Issue #219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Manager Issue Affects the Manager
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@damies13