-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow undefined and pending steps to not fail #862
Conversation
This change introduces most wanted feature that allows to treat undefined/skipped steps as passed and thus not fail scenario. Please review and let me know if this is what you expect! @a1dutch @SteveDonie @laxersaz @ransom4real @silviatejera @sbpk516 @mpkorstanje @imtiazhossain @plank87 @kth13 @svsforsuccess @maultosar @LucasSq @jess8147 @KLBonn @kalyankp @UltimateGeek @ptrthomas @iragoubi @aamol |
Thanks! |
In Cucumber this is called strict/no-strict. By default Cucumber run in no-strict mode. Perhaps rather then selecting which statuses are passed you can provide a single strict flag. That way the report andCucumberi use the same terminology. |
I haven't use default mode I've been using strict. This is valuable comment and I will try to make it easy to use for everyone who know how strict mode works and for those who like to decide which statuses should fail scenario and which don't. |
Thanks, when will this configuration be available on maven-cucumber-reports ? |
The plan stays as: test, write unit test, release this project and then upgrade Jenkins plugin and others. |
Excellent! Much excitement from me. |
@damianszczepanik agree about the strict flag, this is standard cucumber flag and should be the default behaviour. Just supporting the strict mode might be a simpler option, cucumber hasn't seen the need to add any additional configuration for what status's are failed. |
fdf587b
to
87f9082
Compare
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
============================================
- Coverage 97.32% 96.84% -0.48%
+ Complexity 486 485 -1
============================================
Files 48 48
Lines 1045 1046 +1
Branches 85 85
============================================
- Hits 1017 1013 -4
- Misses 17 21 +4
- Partials 11 12 +1
Continue to review full report at Codecov.
|
In which version we have this fixed. I tried with 0.9.5.RC1 but didnt work |
There is no such version https://github.com/damianszczepanik/cucumber-reporting/releases |
Issue #692