improved handling for self-signed certificate validation #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a 2nd method of getting the remote host domain name
eliburke
commented
Oct 23, 2017
…ecks. The existing code would not work in cases where a CA cert was trusted, and the web site used a signed leaf certificate. default behavior is unchanged
|
@daltoniam hey can you let me know if you have an opinion or any complaints on these changes? I'd be happy to explain all of them in more detail, or make changes if you prefer. |
|
@eliburke took me longer than I would like, but finally got around to taking a look at this. The changes make sense, I like it. Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separate disableCertValidation from overrideTrustHostname
add a 2nd method of getting the remote host domain name in sslTrust()