Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/angular update to v17 #516

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Conversation

PhilipAB
Copy link

@PhilipAB PhilipAB commented Dec 7, 2024

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Update to Angular 17 and above
  • Updated/removed deprecated packages
  • Some minor bug fixes (mainly incorrectly typed functions/variables)
  • Fixed CI tests

Does this PR introduce a breaking change?
Yes, requires Angular 17 or higher.

Please check if the PR fulfills these requirements

  • This PR is against the develop branch. (Please do not submit PR's to the master branch)
  • The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
    -> Not sure what the final version numbers will look like. But we could update the Readme.md and encourage people using v5 of this library for Angular versions >= 13 and v6 for Angular versions >= 17.

Other information:
I'm Philip, a contributor of Hobbyfarm, a web-based training plattform. We're using the DateTimePicker within our Admin-UI and while I was updating our project to Angular 17, I did the same for this project :)
I already published a v17-release under my handle, so feel free to test it. You can find it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant