Optimisation for signature verification to succeed fast in checking the scalar #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only done during signature verification.
paragonie-scott
approved these changes
Oct 11, 2019
paragonie-security
added a commit
to paragonie/sodium_compat
that referenced
this pull request
Oct 11, 2019
Based off jedisct1/libsodium#884 which is, in turn, based off dalek-cryptography/ed25519-dalek#99 Thanks @isislovecruft
isislovecruft
added a commit
to isislovecruft/ed25519-elisabeth
that referenced
this pull request
Oct 14, 2019
This is only done upon signature deserialisation/verification. cf. dalek-cryptography/ed25519-dalek#99 for more info.
isislovecruft
added a commit
to isislovecruft/ed25519-elisabeth
that referenced
this pull request
Oct 15, 2019
This is only done upon signature deserialisation/verification. cf. dalek-cryptography/ed25519-dalek#99 for more info.
|
Pretty damn awesome :) |
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Dec 5, 2019
Ensures that the three highest bits of the `s` scalar component of an Ed25519 signature are unset. This doesn't ensure that `s` is fully reduced (which would require a full reduction check in the event that the 4th most significant bit is set), however it will catch a number of invalid signatures relatively cheaply. Inspired by: dalek-cryptography/ed25519-dalek#99
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Dec 5, 2019
Ensures that the three highest bits of the `s` scalar component of an Ed25519 signature are unset. This doesn't ensure that `s` is fully reduced (which would require a full reduction check in the event that the 4th most significant bit is set), however it will catch a number of invalid signatures relatively cheaply. Inspired by: dalek-cryptography/ed25519-dalek#99
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Dec 5, 2019
Ensures that the three highest bits of the `s` scalar component of an Ed25519 signature are unset. This doesn't ensure that `s` is fully reduced (which would require a full reduction check in the event that the 4th most significant bit is set), however it will catch a number of invalid signatures relatively cheaply. Inspired by: dalek-cryptography/ed25519-dalek#99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only done during signature verification.