Feat/favicon missing #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dsr-isrowebapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @pankaj-2503! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and I appreciate your efforts to improve my project.
I will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check my contributing guidelines
|
As you can see mozilla logo in the webpage, similarly we are looking for our website ISRO-web! |
dakshsinghrathore
requested changes
Oct 8, 2023
|
I have made changes and pushed a new PR you can review it and merge
afterwards
…On Sun 8 Oct, 2023, 10:10 PM Daksh Singh Rathore, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
After reviewing the deployed view, I've noticed that there is no favicon
visible.
—
Reply to this email directly, view it on GitHub
<#39 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVO5VAG3DBPH6PT2HRTNNTDX6LJQVAVCNFSM6AAAAAA5XWT7EKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNRTGM2DKMZZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
pankaj-2503
commented
Oct 8, 2023
| @@ -4,6 +4,7 @@ | |||
| <meta charset="UTF-8" /> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
| <link rel="stylesheet" href="css/style.css" /> | |||
There was a problem hiding this comment.
It is showing in website why you are not able to see it i don't understand it
|
See this is visible here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR introduces
What is the need of this PR
Fixes #32