quic: fix flaky ConnectionDebugVisitor test (envoyproxy#35549)

Commit Message: Switch to using `wait_for_log_contains` to fix race condition between stats increment and log flushing when expecting a LOG line caused by QUIC connection closing. Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: Fixes envoyproxy#34492 Signed-off-by: Will Lampert <[email protected]>
daixiang0 · Aug 1, 2024 · 97bc67a · 97bc67a
1 parent 0e03184
commit 97bc67a
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/test/integration/quic_http_integration_test.cc b/test/integration/quic_http_integration_test.cc
@@ -2421,12 +2421,10 @@ TEST_P(QuicHttpIntegrationTest, ConnectionDebugVisitor) {
   EXPECT_TRUE(response->waitForEndStream());
   ASSERT_TRUE(response->complete());
 
-  // TODO(https://github.com/envoyproxy/envoy/issues/34492) fix
-  return;
   EnvoyQuicClientSession* quic_session =
       static_cast<EnvoyQuicClientSession*>(codec_client_->connection());
   std::string listener = version_ == Network::Address::IpVersion::v4 ? "127.0.0.1_0" : "[__1]_0";
-  EXPECT_LOG_CONTAINS(
+  WAIT_FOR_LOG_CONTAINS(
       "info",
       fmt::format("Quic connection from {} with id {} closed {} with details:",
                   quic_connection_->self_address().ToString(),